[BUGFIX] Continue processing psalm-flow graph after first taint sink #5832
Conversation
tests/Config/ConfigTest.php
Outdated
| /** @var \Psalm\Internal\Analyzer\ProjectAnalyzer */ | ||
| protected $project_analyzer; | ||
|
|
||
| public static function setUpBeforeClass() : void | ||
| { | ||
| self::$config = new TestConfig(); | ||
| new TestConfig(); |
There was a problem hiding this comment.
This looks like an unrelated bunch of changes slipped in.
There was a problem hiding this comment.
Nope, since everything inherits from TestCase and there's now an instance property protected $config; (non-static), these changes were necessary.
new TestConfig() in the parts you pointed out was used to initialize their internal static state - self:$config basically had no meaning at all and was never used/retrieved.
There was a problem hiding this comment.
However, I could have created a separate clean-up commit to make that more explicit.
There was a problem hiding this comment.
I'll revert those changes and introduce a new protected TestCase::$testConfig variable instead...
|
Alright, now it's more tailored for the actual change... |
|
Thanks! |
Related: #5830