Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether constructor is internal on new call #5843

Merged
merged 1 commit into from
May 28, 2021
Merged

Check whether constructor is internal on new call #5843

merged 1 commit into from
May 28, 2021

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented May 27, 2021

Fixes #5841

@bdsl
Copy link
Contributor

bdsl commented May 27, 2021

@weirdan probably worth adding a test case for the valid code case where NamespaceAnalyzer::isWithin() returns true, but otherwise LGTM.

@muglug muglug merged commit 0c77ccc into vimeo:master May 28, 2021
@muglug
Copy link
Collaborator

muglug commented May 28, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdsl bdsl bdsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@psalm-internal don't throw error when used for constructor
3 participants
@weirdan @bdsl @muglug