Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add false as return value for mb_convert_encoding #5862

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented May 30, 2021

@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/1887ce60a3
<?php

$x = mb_convert_encoding('test123', 'UTF7-IMAP', 'UTF-8');
if ($x === false) {
 echo 'Nooooo';   
}
Psalm output (using commit 0e8ca1d):

ERROR: TypeDoesNotContainType - 4:5 - string does not contain false

@muglug muglug merged commit 36d670b into vimeo:master Jun 1, 2021
@muglug
Copy link
Collaborator

muglug commented Jun 1, 2021

Thanks!

@kesselb kesselb deleted the bug/false_for_mb_convert_encoding branch June 1, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants