Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit separate type of issue when foreach value is unused #5932

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Emit separate type of issue when foreach value is unused #5932

merged 2 commits into from
Jun 17, 2021

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Jun 15, 2021

Fixes #5929

@weirdan weirdan requested review from muglug and orklah June 15, 2021 03:15
orklah
orklah reviewed Jun 15, 2021
View reviewed changes
config.xsd Outdated Show resolved Hide resolved
@weirdan weirdan marked this pull request as draft June 15, 2021 22:23
@weirdan weirdan marked this pull request as ready for review June 15, 2021 23:08
@weirdan
Copy link
Collaborator Author

weirdan commented Jun 15, 2021

Note that as there's a new class (issue) added this requires a new minor (4.8) release.

@weirdan weirdan requested review from muglug and orklah June 15, 2021 23:11
@muglug muglug merged commit e552925 into vimeo:master Jun 17, 2021
@muglug
Copy link
Collaborator

muglug commented Jun 17, 2021

Thanks! The next release will be 4.8.0, as there'll be a couple of new features to talk about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muglug muglug muglug left review comments

@orklah orklah Awaiting requested review from orklah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit a different subtype of UnusedVariable when it originates from foreach value
3 participants
@weirdan @muglug @orklah