Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong rdkafka commitAsync type #5950

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Fix wrong rdkafka commitAsync type #5950

merged 1 commit into from
Jun 18, 2021

Conversation

danog
Copy link
Collaborator

@danog danog commented Jun 18, 2021

No description provided.

@danog
Copy link
Collaborator Author

danog commented Jun 18, 2021

Also, it seems that the RdKafka\Consumer::newTopic and RdKafka\Producer::newTopic return types aren't actually used during type resolution:

<?php

/** @var \RdKafka\Consumer $a */
$a = null;

$topic = $a->newTopic('test', null);
/** @psalm-trace $topic */;

Result:

INFO: Trace - a.php:7:27 - $topic: RdKafka\Topic (see https://psalm.dev/224)
/** @psalm-trace $topic */;

Should be:

INFO: Trace - a.php:7:27 - $topic: RdKafka\ConsumerTopic (see https://psalm.dev/224)
/** @psalm-trace $topic */;

@muglug muglug merged commit d4311e3 into vimeo:master Jun 18, 2021
@muglug
Copy link
Collaborator

muglug commented Jun 18, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants