Mark return values in throw arguments as used

[weirdan]

Fixes #5975

[weirdan]

I'm not sure whether I really needed to add $context->inside_throw to all of these places, but no tests broke 🤷‍♂️

[muglug]

Thanks!

[frederikbosch]

This method still errors. Why?

    /** @psalm-pure */
    public static function divide(string $amount, string $divisor): string
    {
        if (bccomp($divisor, '0', self::SCALE) === 0) {
            throw InvalidArgumentException::divisionByZero();
        }

        return bcdiv($amount, $divisor, self::SCALE);
    }

ERROR: PossiblyUnusedReturnValue - src/Calculator/BcMathCalculator.php:50:69 - The return value for this method is never used (see https://psalm.dev/273) public static function divide(string $amount, string $divisor): string

[weirdan]

@frederikbosch is it used, and if so, where?

[weirdan]

Also, I don't think this has anything to do with throw, as it's quite unlikely someone throws the result of divide() method.

[orklah]

It seems used at least here: https://github.com/moneyphp/money/blob/2f882263c73d75ddbea49244da5425a9c18289fb/src/Money.php#L265

Also in tests: https://github.com/moneyphp/money/blob/4f9c4fa10f7615a5d7f0c25de6658e0479957be9/tests/Calculator/GmpCalculatorTest.php#L55

and I checked, the tests directory is included in Psalm's analysis

@frederikbosch can you create a new issue for this?

[frederikbosch]

@orklah See #6021