Pass statement to MethodReturnTypeProviderEvent

[VincentLanglet]

I'm trying to solve the following issue on psalm-doctrine: psalm/psalm-plugin-doctrine#77

According to @orklah, this is possible if I can access to the statement from the MethodReturnTypeProviderEvent.

This require to update some signatures.
I added the $stmt param at the same position it was done in #5333
But maybe it can be improved. For instance, I see that both $stmt->args and $stmt are now pass to the getReturnType.

So maybe @muglug @weirdan, you'll prefer I change $stmt->args to $stmt in the original signature.
Or I can just pass $stmt->var.

Also, only the signature MethodReturnTypeProvider::getReturnType is changed ; maybe you'd like I update FunctionReturnTypeProvider::getReturnType too (and FunctionReturnTypeProviderEvent ?) in order to have a similar signature.

Of course, I'm opened to better solution in order to solve psalm/psalm-plugin-doctrine#77 (with psalm assert maybe ?)

[weirdan]

So maybe you'll prefer I change $stmt->args to $stmt in the original signature.

Yes, please. Naturally getCallArgs() method should stay, and just start returning $this->stmt->call_args.

It would be good to keep function type provider signature in sync with method one too.

[VincentLanglet]

So maybe you'll prefer I change $stmt->args to $stmt in the original signature.

Yes, please. Naturally getCallArgs() method should stay, and just start returning $this->stmt->call_args.

It would be good to keep function type provider signature in sync with method one too.

Done ! @weirdan :)

[weirdan]

Thanks!

[VincentLanglet]

Thanks. Is there any strategy about when the new releases are made ?

[weirdan]

I think @muglug just does that from time to time.