Skip argv when --config file.xml is passed

[simPod]

I tried to pass a config file using --config psalm.xml. Though in help (-h) it's specified as --config=psalm.xml.

That resulted in incorrect arg parsing and psalm.xml was set as a path to check.

I'm no sure we want to support it though. Seems like code heavily relies on = being there.

Related to #6056

[weirdan]

I think a better (and more general) fix would be to use third argument to getopt():

$ php -r 'var_dump(getopt("", ["config:"], $rest_offset), $rest_offset, join(" ", array_slice($argv, $rest_offset)));' -- --config config.xml file.php and-a-folder
Command line code:1:
array(1) {
  'config' =>
  string(10) "config.xml"
}
Command line code:1:
int(3)
Command line code:1:
string(21) "file.php and-a-folder"

This will make Psalm require files to check to come last in argument list, but that doesn't sound too bad, especially since passing a non-switch/option argument stops further options from being processed by getopt() anyway.

With that said, I recognize that similar hacks are already in place, so there's no harm in adding this.

[weirdan]

Thanks!