Correct callmap entries for XMLWriter #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
reviewed
Jul 15, 2021
aboks
added a commit
to aboks/psalm
that referenced
this pull request
Jul 16, 2021
aboks
added a commit
to aboks/psalm
that referenced
this pull request
Jul 17, 2021
Checked and fixed the following, based on the current documentation in the PHP manual: * capitalization in method names * parameter names * parameter types (especially for nullable params) * return types (especially for '|false'-types) * differences between pre- and post-8.0.0-signatures Fixes vimeo#6091
weirdan
force-pushed
the
xmlwriter-callmap
branch
from
9d28e34
to
08a80dd
Compare
* `writeDtdEntity()`/`xmlwriter_write_dtd_entity()` has optional params * `xmlwriter_write_attribute_ns` has `$namespace` param as nullable, not `$content` * `xmlwriter_write_element()`/`xmlwriter_write_element_ns()` has `$content` param as optional
|
@aboks I've rebased the PR and added a few fixes |
|
Thanks! |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked and fixed the following, based on the current documentation in the PHP manual:
...|false-types)Fixes #6091