Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detailed return type for strtoupper #6104

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Detailed return type for strtoupper #6104

merged 2 commits into from
Jul 15, 2021

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jul 15, 2021

No description provided.

@orklah
Copy link
Collaborator

orklah commented Jul 15, 2021

Mind adding a nested conditional for non-falsy-string too?

It should be checkef before non-empty-string because it's more narrow

@staabm
Copy link
Contributor Author

staabm commented Jul 15, 2021

Like that?

@orklah
Copy link
Collaborator

orklah commented Jul 15, 2021

Perfect, thanks :)

@weirdan weirdan merged commit c5190f0 into vimeo:master Jul 15, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jul 15, 2021

Thanks!

@staabm staabm deleted the patch-3 branch July 15, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan weirdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@staabm @orklah @weirdan