Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CodeClimateReport): use relative path #6123

Merged
merged 1 commit into from
Jul 16, 2021
Merged

fix(CodeClimateReport): use relative path #6123

merged 1 commit into from
Jul 16, 2021

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jul 16, 2021

Fixes #6122.

@caugner caugner marked this pull request as draft July 16, 2021 20:39
@caugner
Fix CodeClimateReport to use relative paths
d0df69a 
Both GitLab and the Code Climate Engine Specification require the code
climate report to contain the *relative* path to the source code file.
@caugner caugner marked this pull request as ready for review July 16, 2021 20:40
@weirdan weirdan merged commit a6a261b into vimeo:master Jul 16, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jul 16, 2021

Thanks!

@caugner caugner deleted the codeclimate-relative-paths branch July 16, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codeclimate report doesn't work in GitLab, because it uses absolute paths
2 participants
@caugner @weirdan