Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger error #6142

Merged
merged 6 commits into from
Jul 23, 2021
Merged

Trigger error #6142

merged 6 commits into from
Jul 23, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Jul 19, 2021

This will solve #6110

I'm marking this as a draft because I'm waiting for the review before adding the documentation on this.

weirdan
weirdan requested changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build error is already fixed on master branch.

config.xsd Outdated Show resolved Hide resolved
src/Psalm/Internal/Analyzer/ScopeAnalyzer.php Outdated Show resolved Hide resolved
src/Psalm/Internal/Provider/ReturnTypeProvider/TriggerErrorReturnTypeProvider.php Outdated Show resolved Hide resolved
src/Psalm/Internal/Provider/ReturnTypeProvider/TriggerErrorReturnTypeProvider.php Outdated Show resolved Hide resolved
src/Psalm/Internal/Provider/ReturnTypeProvider/TriggerErrorReturnTypeProvider.php Outdated Show resolved Hide resolved
src/Psalm/Internal/Provider/ReturnTypeProvider/TriggerErrorReturnTypeProvider.php Show resolved Hide resolved
weirdan
weirdan reviewed Jul 20, 2021
View reviewed changes
config.xsd Outdated Show resolved Hide resolved
@orklah orklah marked this pull request as ready for review July 22, 2021 21:37
@orklah
Copy link
Collaborator Author

orklah commented Jul 22, 2021

Documentation added. It should be good to merge

@weirdan weirdan merged commit 198fdf8 into vimeo:master Jul 23, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jul 23, 2021

Thanks!

@orklah orklah mentioned this pull request Jul 27, 2021
Closed
@AndrolGenhald AndrolGenhald mentioned this pull request Jul 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muglug muglug muglug left review comments

@weirdan weirdan weirdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orklah @weirdan @muglug