String increment on numeric string #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I've also added documentation for TNonEmptyString and TNonFalsyString in the class because I keep confusing myself between the two and I did it again on this PR when I wondered if "hello"++ should result in TNonEmptyString or TNonFalsyString) |
weirdan
reviewed
Jul 24, 2021
src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOp/NonDivArithmeticOpAnalyzer.php
Outdated
Show resolved
Hide resolved
orklah
force-pushed
the
StringIncrementOnNumericString
branch
from
668a2f8
to
4b660aa
Compare
weirdan
reviewed
Jul 24, 2021
src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOp/NonDivArithmeticOpAnalyzer.php
Outdated
Show resolved
Hide resolved
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows incrementing on a numeric-string without triggering StringIncrement as this is most probably on purpose. Also, it fixes the resulting type from
non-empty-stringtofloat|int. This is particularly useful when working with numeric array-keys due to PHP shenanigans that cast string to int