Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array_slice template parameter return type inference #6170

Merged
merged 2 commits into from
Jul 24, 2021

Conversation

Jack97
Copy link
Contributor

@Jack97 Jack97 commented Jul 24, 2021

This PR updates the ArraySliceReturnTypeProvider to recognise template parameters, and correctly infer the return type of the function when a template parameter is provided.

Closes #6160

@weirdan weirdan merged commit ffbdaa8 into vimeo:master Jul 24, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jul 24, 2021

Thanks!

@Jack97 Jack97 deleted the array-slice-template-params branch July 24, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

array_slice()ing templated array parameter infers array<array-key, mixed>
2 participants