Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DateTimeInterface type reconciliation #6181

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Update DateTimeInterface type reconciliation #6181

merged 3 commits into from
Jul 26, 2021

Conversation

Jack97
Copy link
Contributor

@Jack97 Jack97 commented Jul 26, 2021

As discussed in #6152

DateTimeInterface&!DateTime evaluates to DateTimeImmutable
DateTimeInterface&!DateTimeImmutable evaluates to DateTime

@weirdan weirdan merged commit 358f83d into vimeo:master Jul 26, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jul 26, 2021

Thanks!

@Jack97
Copy link
Contributor Author

Jack97 commented Jul 26, 2021

No worries - happy to help!

@Jack97 Jack97 deleted the date-time-interface-type-reconciliation branch July 26, 2021 13:29
@Jack97 Jack97 mentioned this pull request Jul 27, 2021
Closed
@fox91 fox91 mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jack97 @weirdan