New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider print, and conditionally exit / die impure #6188

Merged

weirdan merged 1 commit into vimeo:master from Jack97:consider-print-exit-die-impure

Jul 27, 2021

Contributor

Jack97 commented Jul 27, 2021

I've updated the PrintAnalyzer to raise an ImpureFunctionCall issue in a mutation-free context.

I've updated the ExitAnalyzer to do the same thing, but only when a non-integer argument is provided.

Closes #6136


          Consider print, and conditionally exit / die impure

f0193f2

weirdan merged commit 813e375 into vimeo:master

Collaborator

weirdan commented Jul 27, 2021

Thanks!

kkmuffme mentioned this pull request

Why is exit/die without arguments pure? #10762

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment