Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make array_replace and array_replace_recursive not nullable #6192

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Jul 27, 2021

This will fix #6186. The only way those function return null is when a wrong parameter is given in input. These kind of errors will be flagged by Psalm and have become a runtime error since PHP8.

@weirdan weirdan merged commit 7aa5564 into vimeo:master Jul 27, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jul 27, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

array_replace_recursive() return type does not contain NULL
2 participants