Improve internals of TIntRange #6208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I also fixed an issue I made that would have transformed and int<0, ?> to TPositiveInt but 0 should not be included) |
muglug
approved these changes
Jul 31, 2021
|
@orklah this requires an expedite patch release, right? Otherwise people may start using what's now in 4.9 |
|
Yeah, this would be great. I'm not too worried about people trying to use it as is a few hours after the release, but if we leave it for days, it might |
|
4.9.1 has just been tagged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I designed the internals of TIntRange was dumb. Trying to fit a single string with a meaning along the integer value is not pratical and not elegant. This replace the string value will null.
Can we push that before considering this a BC break of the release from 3 hours ago?