Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent network issues due to xml.xsd #6229

Merged
merged 6 commits into from Aug 8, 2021
Merged

Conversation

gmessier
Copy link
Contributor

@gmessier gmessier commented Aug 2, 2021

Possible fix #6228

config.xsd Outdated Show resolved Hide resolved
@gmessier
Copy link
Contributor Author

gmessier commented Aug 2, 2021

Ok... I though the changes was so small that I didn't have to understand the pipeline and run tests locally... but seems I will need to dig into it.

@weirdan
Copy link
Collaborator

weirdan commented Aug 2, 2021

I suspect file paths in xsd may be resolved relative to cwd, which would be quite a pain to fix for PHAR.

@gmessier
Copy link
Contributor Author

gmessier commented Aug 3, 2021

For reference: https://stackoverflow.com/questions/22774425/attempting-to-connect-xml-files-with-xinclude-attribute-xmlbase-error
I still try to find another way to be still be able to include file in another directory, but still not need to load the XML schema from the internet (so be able to load it from the PHAR that seems impossible for now).

@gmessier
Copy link
Contributor Author

gmessier commented Aug 3, 2021

The only solution I could find is to allow any attribute to be set in the configuration. XInclude will be able to add the xml:base attribute without breaking the schema validation. It should not be a big problem to allow useless attributes, but it's not to me to take this decision.
The only other solution I can see is to remove this feature and not be able to include file from other directory. IMO if you can only include files from the same directory it's not so useful. It only "clean" a little bit your configuration by having many files with small chunks of the configuration (by example one for the projectFiles, one for the issueHandlers, etc.)

@gmessier gmessier changed the title Add xml.xsd locally to prevent network issues Prevent network issues due to xml.xsd Aug 3, 2021
@weirdan weirdan merged commit 1530121 into vimeo:master Aug 8, 2021
@weirdan
Copy link
Collaborator

weirdan commented Aug 8, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow_url_fopen=1 now required to run Psalm?
2 participants