Literal float methods to Union type
#6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boesing
force-pushed
the
feature/union-float-literal
branch
from
39d31d0
to
02c14fb
Compare
orklah
reviewed
Aug 6, 2021
orklah
reviewed
Aug 6, 2021
- Added `Psalm\Type\Union#isSingleFloatLiteral` - Added `Psalm\Type\Union#getSingleFloatLiteral` - Added `Psalm\Type\Union#hasLiteralFloat` Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
feature/union-float-literal
branch
from
02c14fb
to
9d59fbe
Compare
|
Not sure why Unit Tests - 6 was cancelled x_O |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I recently started to write a plugin to handle #5040
I tried to receive the value of a
floattype but then realized that the union type lacks methods for literal float.In that plugin, i definitely could use
Union#isSingleFloatLiteralalong withUnion#getSingleFloatLiteralandUnion#hasLiteralFloat.This, I'd like to add these methods with this PR. If anything is missing, feel free to hit me up.