fix #5501 #6253
Merged
fix #5501 #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was that Psalm registered the suppression with an offset (cursor position) relative to the beggining of the docblock whereas the expected offset was absolute (from the beggining of the file).
This lead me to send the starting position of the docblock to the parse function to make the addition, and then I had to go back to every place that used this offset to substract the docblock position.
I hope I didn't miss one, this was not easy to do.
I'm not sure if it will fix other similar issues or not, and frankly, I'm not even sure to understand why some suppression work and not other (I think this has to do with which type of docblock and where it need to be parsed)
this fixes #5501