Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constants are non empty strings #6273

Merged
merged 1 commit into from Aug 9, 2021
Merged

Constants are non empty strings #6273

merged 1 commit into from Aug 9, 2021

Conversation

VincentLanglet
Copy link
Contributor

Close #6266

@VincentLanglet VincentLanglet force-pushed the nonEmptyConstant branch 3 times, most recently from 791ec3e to 8fdd0df Compare August 9, 2021 19:39
@VincentLanglet
Copy link
Contributor Author

@weirdan I followed your advice and only return nonEmptyString for the most useful
PHP_VERSION, DIRECTORY_SEPARATOR, PATH_SEPARATOR and PHP_EOL.

@weirdan
Copy link
Collaborator

weirdan commented Aug 9, 2021

Thanks!

@weirdan weirdan merged commit 5dc748d into vimeo:master Aug 9, 2021
@VincentLanglet VincentLanglet deleted the nonEmptyConstant branch August 9, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan weirdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non empty string constants should be considered as a non empty string
2 participants
@VincentLanglet @weirdan