Refactor: constant array type inference #6279
Conversation
| ); | ||
| } | ||
|
|
||
| // if this array looks like an object-like array, let's return that instead |
There was a problem hiding this comment.
Maybe a similar check could be done for inferring TList?
There was a problem hiding this comment.
You mean, for cases where it crossed the threshold for can_create_objectlike?
There was a problem hiding this comment.
I saw multiple cases where can_create_objectlike can be false, so any of those I guess
| ); | ||
| } | ||
| } else { | ||
| $array_creation_info->item_key_atomic_types[] = new Type\Atomic\TInt(); |
There was a problem hiding this comment.
We could probably directly put a TLiteralInt with $int_offset in here I think
There was a problem hiding this comment.
Perhaps. That wouldn't be a refactoring in its strict sense though 😄
To share? I thought so, e.g. |
This brings constant array type inference closer to non-constant analysis, and is a step toward fixing #6263