New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive when passing null to socket_select #6320

Merged

weirdan merged 1 commit into vimeo:master from Forceu:master

Aug 17, 2021

Contributor

Forceu commented Aug 16, 2021 •

edited

Fixes #6318

According to PHP documentation the function is

socket_select(
    ?array &$read,
    ?array &$write,
    ?array &$except,
    ?int $seconds,
    int $microseconds = 0
): int|false

however Psalm did not allow null for $seconds


          Fix for vimeo#6318

weirdan approved these changes

View reviewed changes

weirdan merged commit b343ae5 into vimeo:master

Collaborator

weirdan commented Aug 17, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment