2> Count equal 0 assertion #6423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
force-pushed
the
count-equal-0-negated-assertion
branch
from
ed0c185
to
c0ae10a
Compare
TysonAndre
reviewed
Sep 7, 2021
src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOp/NonDivArithmeticOpAnalyzer.php
Outdated
Show resolved
Hide resolved
orklah
force-pushed
the
count-equal-0-negated-assertion
branch
4 times, most recently
from
7e8c440
to
de6815a
Compare
orklah
force-pushed
the
count-equal-0-negated-assertion
branch
from
d3d027d
to
1f9e4a8
Compare
orklah
force-pushed
the
count-equal-0-negated-assertion
branch
4 times, most recently
from
695cc7e
to
2233993
Compare
orklah
force-pushed
the
count-equal-0-negated-assertion
branch
from
2233993
to
b542daf
Compare
This was referenced Sep 29, 2021
weirdan
approved these changes
Oct 1, 2021
|
Thanks! |
weirdan
added
the
release:fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #6393 and fix #5869. This PR is similar with #5930 but I couldn't finish it at the time because I didn't know about sealed TKeyedArrays and I didn't have IntegerRanges that proved crucial to solve this (this is due to a bug in Psalm, count() was returning a value for non-sealed TKeyedArrays was sometimes incorrect, now an IntegerRange is returned, solving the issue)
EDIT: This will fix #6551
EDIT: This will fix #6548