Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Github Actions output #6818

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Nov 4, 2021

  • Use issue type in title
  • Also provide issue type and location in the (use-visible) error message

Fixes #6817

Screenshots

image

image

image

Demo run

https://github.com/vimeo/psalm/runs/4100401982?check_suite_focus=true#step:4:29

* Use issue type in title
* Also provide issue type and location in the (use-visible) error message

Fixes vimeo#6817
@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 4, 2021
@weirdan weirdan requested a review from orklah November 4, 2021 01:06
@weirdan weirdan force-pushed the improve-github-actions-output branch from cf00672 to 6610a2f Compare November 4, 2021 02:14
@orklah
Copy link
Collaborator

orklah commented Nov 4, 2021

Oh that's really nice! I often wondered if there was something inherent to the format that prevented this, glad I won't have to get this issue!

@weirdan weirdan merged commit 034cb59 into vimeo:master Nov 4, 2021
@weirdan weirdan deleted the improve-github-actions-output branch November 4, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github actions output is missing issue location
2 participants