Fix parameter names in CoreGenericFunctions.phpstub for PHP 8 named p… #6820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
added
the
release:fix
orklah
reviewed
Nov 4, 2021
stubs/CoreGenericFunctions.phpstub
Outdated
| { | ||
| } | ||
|
|
||
| /** | ||
| * @param string $reference | ||
| * @param string $string | ||
| * @param-out null $reference |
There was a problem hiding this comment.
you should change $reference here too. There's probably a few phpdoc tags that possibly contains the param name that should be changed too
|
Thanks for this big work! There's a few tests failing, I believe because some params in phpdoc didn't change names |
|
Damn, I thought I got them all. I'll go through it. |
|
Looks like the remaining failing things are beacuse of array functions I had to change the signature of, not sure how to resolve this. |
|
"test-with-real-projects" failing is unrelated to your PR (and will be removed if you rebase). Other tests appear fine :) |
|
That's great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arameters
A start to fix #6803
I'll see if I can do more, but I'm on holiday the next two weeks and don't know if I can get anything done in that time :)