Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect unevaluated inline-html code after an rearly return #6878

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

pilif
Copy link
Contributor

@pilif pilif commented Nov 10, 2021

this is a followup after #6876

this fixes #6877

@orklah
Copy link
Collaborator

orklah commented Nov 10, 2021

It may have been done to avoid reporting spaces or line feed after closing PHP tag. I'm inclined to accept this, if someone complains, we'll at least have a use case we'll be able to add in test suite...

@pilif
Copy link
Contributor Author

pilif commented Nov 10, 2021

the check was added explicitly in 6550394, but the commit message doesn't give a reason, so we still don't know whether it was intentional

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 10, 2021
@weirdan weirdan merged commit d72b384 into vimeo:master Nov 10, 2021
@weirdan
Copy link
Collaborator

weirdan commented Nov 10, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

psalm does not detect unevaluated inline HTML
3 participants