don't stop processing for class usage after raising an issue #6899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
added
the
release:fix
pilif
commented
Nov 12, 2021
| public function testSeesClassesUsedAfterUnevaluatedCodeIssue(): void | ||
| { | ||
| $this->project_analyzer->getConfig()->throw_exception = false; | ||
| $file_path = getcwd() . DIRECTORY_SEPARATOR . 'tests' . DIRECTORY_SEPARATOR . 'somefile.php'; |
There was a problem hiding this comment.
btw: the other tests in this file use a broken $file_path and only work by accident because the project analyzer is configured to throw rather than record the issue.
the other tests use self::$src_dir_path . 'somefile.php'; which points to the src dir which isn't in the project directory used by the test project_analyzer (which is getcwd() . '/tests' which causes it to not record any issues (the throwing check is happening way before the issue-recording check)
This took me a while to find, especially because everything is nicely failing silently along the path once you tell the config to not throw exceptions.
|
Great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #6887