Fix mb_convert_encoding to accept any array.

[rarila]

Fixes #6886

[orklah]

Thanks! Do you know if the shape of the array is preserved?

If it is, we could create a stub in order to make the array shape pass through the function.

something like

/**
 * @template T of array|string
 * @param T $string
 * @return (T is array ? T : string)
 */

should do the trick

[rarila]

Running tests locally at the moment…
............................................................. 610 / 6499 ( 9%)
two hours later… :-))

Hmm, no, it isn’t. Look at the last example in the issue. String keys are translated, objects/recursively referenced values are replaced.

So I guess, no

[weirdan]

two hours later… :-))

Tests shouldn't be that slow, even with Xdebug enabled (I'd suggest to disable it with, e.g. https://packagist.org/packages/weirdan/run-without-xdebug though).

[orklah]

String keys are translated, objects/recursively referenced values are replaced.

Yeah, string are transformed, but the general shape of the array is kept, no? I mean, if the array was array<int, string> it will stay a array<int, string> right?

[weirdan]

I mean, if the array was array<int, string> it will stay a array<int, string> right?

Yeah, but array{€:string} does not stay that way: https://3v4l.org/djRjL, and you wouldn't be able to express that with templates.

[rarila]

@weirdan Yep.

[weirdan]

Tests shouldn't be that slow

It takes about 5 minutes here, using php-noxdebug vendor/bin/paratest command.

[rarila]

@weirdan gonna try, but I’m already at 44% now – almost done :-)

[orklah]

Oh yeah, forgot about literals in array-shapes.

Guess it would need a return type provider in order to recursively strip any string literal.

It may be worth it one day, returning array is a sure way to trigger a lot of MixedAssignment just by using the returned array

[rarila]

Probably

/**
 * @template T of array|string
 * @param T $string
 * @return (T is array<int, string> ? array<int, string> : 
 *          T is array              ? array : 
 *                                  string)
 */

Would help for most cases

[orklah]

Yeah, it would, Mind adding that to the stubs?

[rarila]

@orklah ok

[orklah]

Note that you have to make a change to CallMap_80 and possibly CallMap_historical for your PR to pass the CI. More is explained here: https://psalm.dev/docs/contributing/editing_callmaps/

[rarila]

@orklah CoreGenericFunctions.phpstub? Just add it at the end?

[rarila]

@orklah

How do you like this format:

/**
 * @template T of array|string
 * @param T $string
 * @return (T is array<int, string> ? array<int, string> : 
 *          T is array              ? array : 
 *          T is string             ? string :
 *                                    never)
 */

I like it that way because it lists all possible options and is quite readable that way.

[orklah]

Please don't add never at the end. Listing the allowed params is enough to make Psalm emit an issue. Adding never will just create a whole new set of weird errors that will be irrelevant

[rarila]

@orklah ok.

Looking at the other callmaps now…

If I see it right, I'll have to remove the array version from CallMap_historical.php, add it to 'added' CallMap_72_delta.php?!

[orklah]

nah, you have to change the signature in CallMap_80 "new" to match with the one in your CallMap file and then, if needed, change the CallMap_historical to match with the CallMap_80 "old" (we start from CallMap and then process each delta file from newer to older untli CallMap_historical)

[rarila]

I think I have it, running tests…

[orklah]

Oh, nice catch! I didn't know arrays were introduced in 7.2

[rarila]

At least the manual says so :-)

[orklah]

we should add |false everywhere in the return types

[rarila]

Ah, good catch. But only at the string return.

I still wonder what happens, when you add a string that triggers returning false for a string into an array…

[orklah]

Can you add a @psalm-ignore-falsable-return on the stub? It will allow people with the config disabled to not handle the false return without getting errors

[rarila]

@orklah Here you are :-)

[orklah]

Thank you! That's great!

[rarila]

No, I have to thank for this great tool!