Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test runnable on plain windows #7005

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

rarila
Copy link
Contributor

@rarila rarila commented Nov 26, 2021

Running composer all-tests or composer psalm fails on (standard) Windows as it doesn’t care for the shebang.

Executing the script as in this patch should (hopefully, we’ll see :-) independent of the OS.

@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Nov 26, 2021
@orklah orklah merged commit c46e67a into vimeo:master Nov 26, 2021
@orklah
Copy link
Collaborator

orklah commented Nov 26, 2021

Great! Thanks!

@rarila rarila deleted the fix-tests-failing-on-windows branch November 26, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants