Display target PHP version #7006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
added
enhancement
release:feature
Historically it was often not quite clear to users what PHP version Psalm assumes, and why. This PR addresses this issue by printing the version and where we got it from right before scanning the files.
weirdan
force-pushed
the
show-php-version
branch
from
016bff5
to
d19aad7
Compare
orklah
reviewed
Nov 27, 2021
|
|
||
| if (isset($options['php-version'])) { | ||
| if (!is_string($options['php-version'])) { | ||
| die('Expecting a version number in the format x.y' . PHP_EOL); |
There was a problem hiding this comment.
This check can be dropped here, it seems to be checked again in project analyzer below
There was a problem hiding this comment.
It is to avoid MixedAssignment to $version variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically it was often not quite clear to users what PHP version Psalm assumes, and why. This PR addresses this issue by printing the version and where we got it from right before scanning the files.
Note that psalm/psalm.dev#69 has to merged first lest psalm.dev sandbox become unusable.