Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore irrelevant errors for php-parser 4.13.2 #7033

Merged
merged 1 commit into from Nov 30, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Nov 30, 2021

CI is failing since php-parser 4.13.2

This is due to a new property that has been materialized (it was a @Property before). Now that it's a real property, Psalm require every child from this class to have a construct who initialize the property, but there's not.

I baselined those errors, they make little sense here.

@orklah orklah added the release:fix label Nov 30, 2021
@orklah orklah merged commit b70466c into vimeo:master Nov 30, 2021
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant