document the behavior of methods in IssueBuffer #7040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
added
the
release:docs
weirdan
reviewed
Dec 1, 2021
| @@ -145,8 +148,11 @@ public static function addUnusedSuppression(string $file_path, int $offset, stri | |||
| } | |||
|
|
|||
| /** | |||
| * This will return true if an issue is ready to be added for emission. Reasons for not returning true include: | |||
There was a problem hiding this comment.
Are you sure it's not the opposite?
There was a problem hiding this comment.
You're right, I'm changing that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents my findings when looking at #7038