Skip to content

Drop legacy procedural files #7270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weirdan merged 1 commit into from
Jan 3, 2022
Merged

Drop legacy procedural files #7270

weirdan merged 1 commit into from
Jan 3, 2022

Conversation

@weirdan
Copy link
Collaborator

@weirdan weirdan commented Jan 3, 2022

No description provided.

@weirdan weirdan added the release:removed The PR will be included in 'Removed' section of the release notes label Jan 3, 2022
@weirdan weirdan added this to the Psalm 5 milestone Jan 3, 2022
@weirdan weirdan requested a review from orklah January 3, 2022 10:06
@weirdan weirdan merged commit b8bad62 into vimeo:master Jan 3, 2022
@weirdan weirdan deleted the drop-legacy-binaries branch January 3, 2022 10:10
@orklah
Copy link
Collaborator

orklah commented Jan 3, 2022

I believe spl_object_id can be dropped too, as soon as we raise our min PHP version. The polyfill was there for PHP 7.1

@weirdan
Copy link
Collaborator Author

weirdan commented Jan 3, 2022

I believe spl_object_id can be dropped too

Yes, I left it for the PR bumping the minimum PHP version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orklah orklah Awaiting requested review from orklah

Assignees

No one assigned

Labels

release:removed The PR will be included in 'Removed' section of the release notes

Projects

None yet

Milestone

Psalm 5

Development

Successfully merging this pull request may close these issues.

2 participants

@weirdan @orklah