Finalize issues

[weirdan]

No description provided.

[pilif]

This is indeed a bit of a shame.

In our code-base, we have some legacy patterns we want to discourage and I wrote a plug-in to find those and raise a deprecation issue.

But I’m reporting an anonymous subclass of the issue and set the URL to point to our wiki with a more detailed explanation (by overriding toIssueData)

If you need to make these final, please consider letting plugins provide URLs and message overrides.

[weirdan]

Is there any reason you're not extending PluginIssue instead?

psalm/src/Psalm/Issue/PluginIssue.php

Line 5 in b06fb93

abstract class PluginIssue extends CodeIssue

[pilif]

Because the pattern is about a deprecation, so using the native deprecation made sense with regards to configuration how to deal with deprecations in which directories.

Basing the issue in PluginIssue produces a secondary hierarchy of issues which needs a separate configuration.