DateInterval::createFromDateString can be false

[Ne-Lexa]

Fixes #7747

[orklah]

Thanks! Can you also do this change in Callmap_historical? There should be a match between Callmap (who is the current state) and another Callmap file (who'll show when this particular signature was introduced)

[Ne-Lexa]

@orklah, changes made.

[orklah]

Thanks!

[orklah]

And congrats for your first PR!

[boesing]

Was this possibly reverted?

Does not create an issue in 4.26 nor in latest 5.x commit:
https://psalm.dev/r/49ce1d4e62

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/49ce1d4e62

<?php

function foo(): DateInterval
{
    return DateInterval::createFromDateString('foo');
}

Psalm output (using commit afe85fa):

No issues!

[AndrolGenhald]

@boesing Still works, that's just ignoreInternalFunctionFalseReturn being annoying.

The fact that there are so many config values that most people never look at, and the amount of work it takes to go through all of them manually, is what motivated me to open #7630, but I've been short on time lately. If you or someone else wants to go through the options and decide what value is "strictest" for each of them I would guess the actual implementation of it should be relatively simple.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/760586cee1

<?php

function foo(): DateInterval
{
    $foo = DateInterval::createFromDateString('foo');
    /** @psalm-trace $foo */
    return $foo;
}

Psalm output (using commit afe85fa):

INFO: Trace - 7:5 - $foo: DateInterval|false