Fix #7750: array_column type inference #7760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add one more test when index key not exist in array reorganise samples to keep all similar together
|
Why |
|
You're right @alex-dev, fixed 馃槂 |
orklah
reviewed
Mar 6, 2022
src/Psalm/Internal/Provider/ReturnTypeProvider/ArrayColumnReturnTypeProvider.php
Outdated
Show resolved
Hide resolved
From: vimeo#7760 (comment) $result_element_type should be a Union, $row_shape is an Atomic (a part of a Union). new Union([$row_shape]); should be ok
orklah
added
the
release:fix
orklah
reviewed
Mar 6, 2022
src/Psalm/Internal/Provider/ReturnTypeProvider/ArrayColumnReturnTypeProvider.php
Outdated
Show resolved
Hide resolved
|
That's great! Thanks! Congrats for your first PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposition of fixing this problem #7750
I was trying to keep the similar tests together, so this change looks a bit unclear in diff.
That's my first contribution to the psalm, so sorry if something is wrong 馃槃