Bugfix/#7912 class APCuIterator does not exist #7982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoboss
approved these changes
May 18, 2022
|
Looks great. @AndrolGenhald can you check if we missed something? I have a vague memory that we have a list of supported extensions somewhere? |
|
I think this is all that's needed for Psalm 4, but it'll probably have issues when merging to master. I might try to open a PR to merge 4.x to master later while undoing part of this and including the new extension stuff. It's still unclear to me why the CallMap doesn't work in this case, but my personal goal is to remove extensions from the CallMap anyway 🤷 |
orklah
added
the
release:feature
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7912