-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DOM stub and add separate SimpleXML stub #8140
Conversation
|
||
public function valid(): bool {} | ||
|
||
public function current(): SimpleXMLIterator {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically incorrect, it can return null until PHP 8.1, but I don't think calling current()
directly is very common, so it's probably preferable to trade the very uncommon false negative for much more common false positives.
Related to php/doc-en#1640
foreach ($xml->children() as $img) { | ||
$children = $xml->children(); | ||
assert($children !== null); | ||
foreach ($children as $img) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a false negative: https://3v4l.org/rqvMc
Thanks! |
No description provided.