Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include CLI args in PHP errors to more quickly identify run issues in CI #8724

Merged
merged 1 commit into from Nov 20, 2022

Conversation

kkmuffme
Copy link
Contributor

When errors are collected in a general log, identifying the origin Psalm command requires multiple additional steps if Psalm encounters an PHP error. Including the CLI args in the error makes this much quicker.

@kkmuffme kkmuffme force-pushed the include-cli-args-in-php-errors branch from 3f9cb3d to 0bebf6c Compare November 20, 2022 10:08
@kkmuffme kkmuffme force-pushed the include-cli-args-in-php-errors branch from 0bebf6c to ce84a80 Compare November 20, 2022 10:15
@kkmuffme kkmuffme marked this pull request as ready for review November 20, 2022 10:22
@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Nov 20, 2022
@weirdan weirdan merged commit 7869cb5 into vimeo:master Nov 20, 2022
@weirdan
Copy link
Collaborator

weirdan commented Nov 20, 2022

Thanks!

@kkmuffme kkmuffme deleted the include-cli-args-in-php-errors branch November 20, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants