Skip to content

fix sealed combination #8798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orklah merged 2 commits into from
Dec 1, 2022
Merged

fix sealed combination #8798

orklah merged 2 commits into from
Dec 1, 2022

Conversation

@orklah
Copy link
Collaborator

@orklah orklah commented Nov 30, 2022

This will fix #8719

We were creating an non-empty-array based on the fact that there were sealed properties without actually checking if they could be undefined

@danog could you review that? Not sure if it was the best move here

@danog
Copy link
Collaborator

danog commented Dec 1, 2022 •
edited
Loading

LGTM!
The logic seems correct to me, even if I would've used a simple ! instead of !== true for readability :)

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 1, 2022
@orklah orklah merged commit b4aa951 into vimeo:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release:fix The PR will be included in 'Fixes' section of the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Psalm incorrectly identifying array as non-empty-array

2 participants

@orklah @danog