Fix #8806

[danog]

No description provided.

[orklah]

Thanks!

[weirdan]

https://psalm.dev/r/fd479a295e - it still fails on psalm.dev

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/fd479a295e

<?php

array_map(null, [1]);

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/Provider/ReturnTypeProvider/ArrayMapReturnTypeProvider.php: Psalm\Internal\Provider\ReturnTypeProvider\ArrayMapReturnTypeProvider::Psalm\Internal\Provider\ReturnTypeProvider\{closure}(): Argument #1 ($sub) must be of type array, Psalm\Type\Union given

[orklah]

phar build seems broken, it doesn't launch. Maybe related to failed CI?

[weirdan]

it doesn't launch

Doesn't it? I see a non-crashing run right here in this ticket: https://app.circleci.com/pipelines/github/vimeo/psalm/10128/workflows/d1c6c5c6-09e3-49ca-bd07-e0656013a83d/jobs/35716

[orklah]

Yeah but there's no artifact. Also, the CI on master branch says "Build phar / build-phar (push) Skipped"

[weirdan]

psalm.phar artifact is produced in a previous job (of the same workflow): https://app.circleci.com/pipelines/github/vimeo/psalm/10128/workflows/d1c6c5c6-09e3-49ca-bd07-e0656013a83d/jobs/35715/artifacts

GH Actions build-phar.yml could be skipped if there are duplicate jobs running (because they would fail to push the results to psalm/phar): https://github.com/vimeo/psalm/blob/master/.github/workflows/build-phar.yml#L15-L29

[weirdan]

Anyway it won't affect psalm.dev as we don't run phar there as far as I know.

[orklah]

I thought it did for running psalm.

Anyway, Psalm.dev is running with commit c3cc906 which is outdated (but I'm not sure why now...)

[weirdan]

@muglug can you check why vimeo/psalm does not get updated on psalm.dev? I don't think anyone else can do that.

[muglug]

Ah I've bumped this now