Skip to content

fix return type never for static function calls#8902

Merged
orklah merged 1 commit intovimeo:masterfrom
kkmuffme:fix-never-static-calls
Dec 16, 2022
Merged

fix return type never for static function calls#8902
orklah merged 1 commit intovimeo:masterfrom
kkmuffme:fix-never-static-calls

Conversation

@kkmuffme
Copy link
Contributor

No description provided.

@kkmuffme kkmuffme force-pushed the fix-never-static-calls branch from 128e9b2 to eeb0c06 Compare December 16, 2022 10:55
@kkmuffme kkmuffme marked this pull request as ready for review December 16, 2022 11:05
@kkmuffme
Copy link
Contributor Author

@orklah please merge, thx

@orklah
Copy link
Collaborator

orklah commented Dec 16, 2022

Please add a test so we don't break this in the future

@kkmuffme
Copy link
Contributor Author

There's already one for the exact same condition in the part before the OR condition

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 16, 2022
@orklah
Copy link
Collaborator

orklah commented Dec 16, 2022

Thanks, but please still add a test next time. It really helps us with the context of a given change. You know perfectly what you changed and you understand why. Looking at your PR, I don't even have an example of what kind of code you're trying to fix and you expect me to review how you fixed it, that's really hard.

@orklah orklah merged commit 5afc328 into vimeo:master Dec 16, 2022
@kkmuffme kkmuffme deleted the fix-never-static-calls branch December 28, 2022 14:21
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:fix The PR will be included in 'Fixes' section of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants