Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 9433 #9436

Closed
wants to merge 0 commits into from
Closed

Issue 9433 #9436

wants to merge 0 commits into from

Conversation

ptomulik
Copy link
Contributor

@ptomulik ptomulik commented Mar 1, 2023

An attempt to fix #9433. Some errors appeared, reported by "Run Shepherd" action. Need a little guidance to fix this, but it looks like the immediate effect of bug fixing (i.e. the code seemed to work thanks to false-negative behavior, that has just been fixed here).

@weirdan
Copy link
Collaborator

weirdan commented Mar 1, 2023

Some errors appeared, reported by "Run Shepherd"

ImpureFunctionCall errors are from another problematic (now reverted) PR. Please rebase.

@ptomulik
Copy link
Contributor Author

ptomulik commented Mar 1, 2023

I've just messed things up (force pushed master as to this branch and lost my changes)... gosh. One stupid mistake at the morning ;)

@weirdan
Copy link
Collaborator

weirdan commented Mar 1, 2023

image

You can reset the branch to the way it was before your force-push: git reset --hard f078382

@ptomulik
Copy link
Contributor Author

ptomulik commented Mar 1, 2023

The changes were small, so I just managed to reproduce them manually.

@ptomulik ptomulik mentioned this pull request Mar 1, 2023
@ptomulik
Copy link
Contributor Author

ptomulik commented Mar 2, 2023

Opened new PR #9439 to continue work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IfAnalyzer incorrectly updates outer scope
2 participants