Return error to callback #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
By the way, these types of errors would be caught by TypeScript if this project would be open to converting... |
17 tasks
|
Thanks - definitely a bug, will release this tomorrow in a 2.2 version bump. |
aaronm67
approved these changes
Jul 21, 2022
typescript-bot
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jul 21, 2022
* Fix error type References: - https://github.com/vimeo/vimeo.js/blob/343276ad653cf0370f20dd105ec7a40acba80530/lib/vimeo.js#L104 - https://github.com/vimeo/vimeo.js/blob/343276ad653cf0370f20dd105ec7a40acba80530/lib/vimeo.js#L138 - https://github.com/vimeo/vimeo.js/blob/343276ad653cf0370f20dd105ec7a40acba80530/lib/vimeo.js#L164-L165 - https://github.com/vimeo/vimeo.js/blob/343276ad653cf0370f20dd105ec7a40acba80530/lib/vimeo.js#L177 PR open in the library for line 174, which appears to be an error: vimeo/vimeo.js#155 * Fix version number * Fix tests * Remove patch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your work on vimeo.js!
The first argument of the callback should be an error, not a buffer.
cc @aaronm67