Upload progress #35
Merged
Upload progress #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var file = new FileStreamer(path, ticket.upload_link_secure); | ||
|
|
||
| if (progress_callback) { | ||
| var check_progress = setInterval(function () { |
There was a problem hiding this comment.
Do we have to do set interval here? My gut feels like there's a better way.
Can we just pass the progress callback into the filestreamer so we have it called exactly when it's updated, as opposed to periodically checking via the event loop?
formatting convert tabs to spaces back to tabs
convert tabs to spaces convert spaces to tabs
zenahirsch
force-pushed
the
upload_progress
branch
from
b12de21
to
93e7e98
Compare
|
👍 for upload fix and tabs standardization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes based on #34:
startvariable to calculateuploadProgress