Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version 3.0.4 is broken #239

Closed
AsdYo opened this issue Dec 6, 2019 · 4 comments
Closed

Latest version 3.0.4 is broken #239

AsdYo opened this issue Dec 6, 2019 · 4 comments

Comments

@AsdYo
Copy link

AsdYo commented Dec 6, 2019

Currently, as I mentioned in this thread #237, the v3.0.4 package is broken, throwing
In Vimeo.php line 596: Attempted to call an undefined method named "setUrl" of class "TusPhp\Tus\Client".
I understand that manually adding the setter to the other class fixes the issue, but this is not how it should be done and with the next package update it will probably get reverted again...

@samundra
Copy link

samundra commented Dec 6, 2019

@AsdYo With due respect, I wonder how setUrl got into TusPhp\Tus\Client in first place. Was it added manually? 🤔

@AsdYo
Copy link
Author

AsdYo commented Dec 6, 2019

@samundra Well... Judging also by the other comments there, I guess manually, yes... It's not in the versioned files :)

@simpleeducation
Copy link

This is completely wrong.
Please fix it guys, everthing are going to be broken at the deployment moment.

@AsdYo
Copy link
Author

AsdYo commented Dec 13, 2019

Thanks for the 3.0.5 fix :)

@AsdYo AsdYo closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants