Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main.go rely on internal package import #7

Closed
Alopex4 opened this issue Jan 6, 2024 · 3 comments
Closed

main.go rely on internal package import #7

Alopex4 opened this issue Jan 6, 2024 · 3 comments
Labels

Comments

@Alopex4
Copy link

Alopex4 commented Jan 6, 2024

Hi Vimiix,
As a newbie Go developer, I found the ssx/cmd/ssx/main.go relies on internal import "github.com/vimiix/ssx/internal/cleaner".
In the Goland IDE it will cause an error until I modify it to "ssx/internal/cleaner".

Do you consider to move the cleaner out of internal package or give it a hook function for public involve?

If there are any mistakes or omissions in what I have mentioned, please point them out. Thank you.

@vimiix
Copy link
Owner

vimiix commented Jan 8, 2024

@Alopex4
github.com/vimiix/ssx is module path of current project, it is defined in go.mod. If your go version is greater than v1.11, it should be indexed correctly.

Of course, we also can consider moving cleaner into the ssx module.

@vimiix
Copy link
Owner

vimiix commented Jan 8, 2024

I have just moved the cleaner module into the ssx module, and I will release this change in next version.

commit: 896735b

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants