Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio/Visual bell when following hints #718

Closed
vpetro opened this issue Feb 17, 2017 · 4 comments
Closed

Audio/Visual bell when following hints #718

vpetro opened this issue Feb 17, 2017 · 4 comments

Comments

@vpetro
Copy link

vpetro commented Feb 17, 2017

Issue type:
  • Bug report
Version:
Vimperator:	3.16.0.20170217123651 (created: 2017/02/17 12:36:51)
Firefox:	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:51.0) Gecko/20100101 Firefox/51.0
Description:

Error bell triggered when following hints. The hint action doesn't make a difference. Following regular hints (type f and then type the number) or extended hints with ;ANYTHING results in either visual or audible error bell (depending on configuration value).

Expected behavior:

I expect the error bell not to be invoked when following valid hints.

Steps to reproduce:
  • go to any page that has links
  • press f
  • type the any hint number
  • observe audible or visual bell
@SammysHP
Copy link
Member

I'm not able to reproduce this.

jspam added a commit to jspam/vimperator-labs that referenced this issue Feb 18, 2017
@jspam
Fix vimperator#718: Do not call _processHints after following a uniqu…
bc00c13 
…e hint.

When following a unique hint, the `validHints` array is cleared, thus
the second call of _processHints triggers a beep() after following a hint.
jspam added a commit to jspam/vimperator-labs that referenced this issue Feb 18, 2017
@jspam
Fix vimperator#718: Do not call _processHints after following a uni…
05921d3 
…que hint.

When following a unique hint, the `_validHints` array is cleared, thus
the second call of `_processHints` triggers a `beep()` after
following a hint.
@harciga
Copy link

harciga commented Feb 19, 2017

Ahh, this is killing me too. And to think it's going to take weeks for Mozilla to approve any updates...

@jstetten
Copy link

Looks like @jspam submitted a patch.

@harciga and anyone else, the bell can be temporarily silenced with :set visualbell=true.

@vpetro
Copy link
Author

vpetro commented Feb 21, 2017

The PR has been approved. I am not sure who is responsible for merging it.

Another solution is to build a version of vimperator that includes the patch.

I also would like to say "thank you" to @jspam for the code and @SammysHP for reviewing it.

@rndusr rndusr mentioned this issue Feb 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vpetro @jstetten @SammysHP @harciga